Tag: github

In my first few weeks at my new employer, my code contributions have added 218 lines of code, deleted 2,663. Only one of my PRs has resulted in a net increase in the size of their codebases (by two lines).

Alt

GitHub change summary showing +218 lines added, -2,663 lines removed.

I need to pick up the pace if I'm going to reach the ultimate goal of deleting ALL of the code within my lifetime. (That's the ultimate aim, right?)

Not every code review is fireworks, but most Three Rings changes come from the actual needs of the voluntary organisations that Three Rings supports. Some of our users were confused by the way the Admin > Roles page was laid out, so one of our volunteers wrote an improved version.

And because we're all about collaboration, discussion, learning from one another, and volunteer-empowerment... I've added a minor suggestion... but approved their change "with or without" it. I trust my fellow volunteer to either accept my suggestion (if it's right), reject it (if it's wrong), or solicit more reviews or bring it to Slack or our fortnightly dev meeting (if it requires discussion).

Alt

GitHub screenshot showing a suggested change to a pull request. Dan-Q is suggesting that the new sentence 'These roles belong to .' should not have a full stop at the end, for consistency with other similar headings.

My first task this International Volunteer Day is to test a pull request that aims to fix a bug with Three Rings' mail merge fields functionality. As it's planned to be a hotfix (direct into production) we require extra rigor and more reviewers than code that just goes into the main branch for later testing on our beta environment.

My concern is that fixing this bug might lead to a regression not described by our automated tests, so I'm rolling back to a version from a couple of months ago to compare the behaviour of the affected tool then and now. Sometimes you just need some hands-on testing!

Alt

Screenshot showing web application Three Rings viewed on a local development machine, being used to compose an email about International Volunteer Day. A merge field called 'first_name' is included in the email, and it's hand-annotated with the question 'working?'. Alongside, GitHub Desktop shows that we've rolled-back to a revision from two months ago.

Day #2 of my sabbatical had a morning in which I've mostly been roped into some charity-related digital forensics... until I got distracted by dndle.app, which apparently I accidentally broke yesterday! Move Fast and Fix Things!

Alt

Dan, looking concerned, in front of Github and Dndle.app.